New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log captured errors sooner #10373

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
3 participants
@bvaughn
Contributor

bvaughn commented Aug 3, 2017

This prevents the captured error from becoming separated from the component stack if other errors (or console.error calls) are made between them, eg a component errors during unmount.

Relates to discussion on #10353 as well as out-of-band (not on GitHub) discussion.

Before

screen shot 2017-08-03 at 11 39 29 am

After

screen shot 2017-08-03 at 2 48 53 pm

Log captured errors sooner
This prevents the captured error from becoming separated from the component stack if other errors (or console.error calls) are made between them, eg a component errors during unmount.
@gaearon

gaearon approved these changes Aug 3, 2017

Lg

@bvaughn bvaughn merged commit 6188832 into facebook:master Aug 3, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@bvaughn bvaughn deleted the bvaughn:log-captured-errors-sooner branch Aug 3, 2017

@bvaughn bvaughn referenced this pull request Aug 3, 2017

Closed

React 16 RC #10294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment