New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better messaging for componentDidCatch cross-origin errors #10447

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
4 participants
@bvaughn
Contributor

bvaughn commented Aug 12, 2017

The prior message was a bit wordy and didn't cover all cases (like the one we discovered while researching #10441).

We can use the new URL to explain background info on the DEV-mode technique we're using in addition to common fixes (eg crossorigin attribute for CDN scripts and Webpack devtools settings). Putting this information behind a link will allow us to more easily edit it in the future as common causes for this issue change.

Resolves #10441

Note I have not yet setup the fb.me/react-crossorigin-error shortcut or written the content that will live there. It's been a long day and I'm taking off. Technically we can merge this at any time (to unblock the RC) and just follow-up with the link soon. Or I'll add it on Monday if we're not in a hurry. 馃槃

Better messaging for componentDidCatch cross-origin errors
The prior message was a bit wordy and didn't cover all cases (like the one we discovered while researching #10441).

We can use the new URL to explain background info on the DEV-mode technique we're using in addition to common fixes (eg crossorigin attribute for CDN scripts and Webpack devtools settings). Putting this information behind a link will allow us to more easily edit it in the future as common causes for this issue change.

Resolves #10441

@gaearon gaearon referenced this pull request Aug 12, 2017

Closed

React 16 Umbrella 鈽傦笍 (and 15.5) #8854

117 of 120 tasks complete

@bvaughn bvaughn merged commit 6c6ff8c into facebook:master Aug 14, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@bvaughn bvaughn deleted the bvaughn:componentDidError-cross-origin-message branch Aug 14, 2017

@bvaughn

This comment has been minimized.

Show comment
Hide comment
@bvaughn

bvaughn Aug 14, 2017

Contributor

New docs page follow-up in #10457

Contributor

bvaughn commented Aug 14, 2017

New docs page follow-up in #10457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment