New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10443 #10448

Merged
merged 1 commit into from Aug 12, 2017

Conversation

Projects
None yet
4 participants
@fxfactorial
Contributor

fxfactorial commented Aug 12, 2017

No description provided.

@acdlite

Make sure you run yarn prettier and commit the result.

Show outdated Hide outdated src/renderers/native/findNodeHandle.js
Show outdated Hide outdated src/renderers/native/findNodeHandle.js
@fxfactorial

This comment has been minimized.

Show comment
Hide comment
@fxfactorial

fxfactorial Aug 12, 2017

Contributor

@acdlite Done, I forgot that FB prefers trailing ,, force pushed

Contributor

fxfactorial commented Aug 12, 2017

@acdlite Done, I forgot that FB prefers trailing ,, force pushed

@fxfactorial

This comment has been minimized.

Show comment
Hide comment
@fxfactorial

fxfactorial Aug 12, 2017

Contributor

@acdlite I think that should cover it.

Contributor

fxfactorial commented Aug 12, 2017

@acdlite I think that should cover it.

@acdlite acdlite merged commit 2cd0ecd into facebook:master Aug 12, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@acdlite

This comment has been minimized.

Show comment
Hide comment
@acdlite

acdlite Aug 12, 2017

Member

Thanks!

Member

acdlite commented Aug 12, 2017

Thanks!

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Aug 23, 2017

Member

This is not enough to fix the issue. Please see #10518.

Member

gaearon commented Aug 23, 2017

This is not enough to fix the issue. Please see #10518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment