New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit invariant when ReactDOM is loaded without React #10449

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
3 participants
@aweary
Member

aweary commented Aug 12, 2017

Resolves #10406

@aweary aweary requested a review from gaearon Aug 12, 2017

@gaearon

Accepted with nits above

Show outdated Hide outdated src/renderers/dom/shared/checkReact.js
Show outdated Hide outdated src/renderers/dom/shared/checkReact.js
Show outdated Hide outdated src/renderers/dom/shared/checkReact.js

@aweary aweary merged commit 5ff5700 into facebook:master Aug 13, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@bvaughn bvaughn referenced this pull request Sep 7, 2017

Closed

React 16 RC #10294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment