New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about casing in SSR for non-HTML NS #10452

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
3 participants
@sophiebits
Member

sophiebits commented Aug 13, 2017

Fixes #10415.

@sophiebits sophiebits requested a review from flarnie Aug 13, 2017

@flarnie

Thanks for doing this! Makes sense to me.

@@ -343,6 +319,8 @@ var ReactDOMFiberComponent = {
}
if (namespaceURI === HTML_NAMESPACE) {
if (__DEV__) {
// Should this check be gated by parent namespace? Not sure we want to
// allow <SVG> or <mATH>.

This comment has been minimized.

@flarnie

flarnie Aug 13, 2017

Contributor

nit - probably meant "<MATH>" not "<mATH>"

@flarnie

flarnie Aug 13, 2017

Contributor

nit - probably meant "<MATH>" not "<mATH>"

This comment has been minimized.

@sophiebits

sophiebits Aug 13, 2017

Member

This is what I meant. :)

@sophiebits

sophiebits Aug 13, 2017

Member

This is what I meant. :)

@@ -772,4 +772,36 @@ describe('ReactDOMServer', () => {
);
}).toThrowError(/Cannot assign to read only property.*/);
});
it('warns about lowercase html but not in svg tags', () => {

This comment has been minimized.

@flarnie

flarnie Aug 13, 2017

Contributor

awesome - thanks for adding a test!

@flarnie

flarnie Aug 13, 2017

Contributor

awesome - thanks for adding a test!

@gaearon gaearon referenced this pull request Aug 13, 2017

Closed

React 16 Umbrella ☂️ (and 15.5) #8854

117 of 120 tasks complete

@sophiebits sophiebits merged commit 5e85f00 into facebook:master Aug 13, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details

@bvaughn bvaughn referenced this pull request Sep 7, 2017

Closed

React 16 RC #10294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment