New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attribute follow up #10470

Merged
merged 2 commits into from Aug 16, 2017

Conversation

Projects
None yet
3 participants
@nhunzaker
Collaborator

nhunzaker commented Aug 16, 2017

Follow up from #10385.

  • Adds backticks around props in ReactDOMInvalidARIAHook. This is consistent with ReactUnknownDOMPropertyHook
  • Fixes test names in server integration tests to reflect the change in behavior of custom attributes

@gaearon gaearon merged commit 5ba1803 into facebook:master Aug 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@@ -94,7 +94,7 @@ function validateProperty(tagName, name, debugID) {
if (name !== standardName) {
warning(
false,
'Unknown ARIA attribute %s. Did you mean %s?%s',
'Unknown ARIA attribute `%s`. Did you mean `%s`?%s',

This comment has been minimized.

@gaearon

gaearon Aug 18, 2017

Member

Why do we use Invalid wording everywhere except here?

@gaearon

gaearon Aug 18, 2017

Member

Why do we use Invalid wording everywhere except here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment