New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "const" in uncompiled code #10631

Merged
merged 1 commit into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@sophiebits
Member

sophiebits commented Sep 7, 2017

Test Plan: All fixtures/packaging iframes display correctly on Chrome 38.0.2125.0 from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/290001/; previously several were blank with "Use of const in strict mode" errors logged to the console.

Remove "const" in uncompiled code
Test Plan: All fixtures/packaging iframes display correctly on Chrome 38.0.2125.0 from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/290001/; previously several were blank with "Use of const in strict mode" errors logged to the console.

@sophiebits sophiebits merged commit 16a39b8 into facebook:master Sep 7, 2017

1 check was pending

ci/circleci Your tests are queued behind your running builds
Details

@bvaughn bvaughn referenced this pull request Sep 7, 2017

Closed

React 16 RC #10294

flarnie added a commit to flarnie/react that referenced this pull request Sep 8, 2017

Remove "const" in uncompiled code (#10631)
Test Plan: All fixtures/packaging iframes display correctly on Chrome 38.0.2125.0 from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/290001/; previously several were blank with "Use of const in strict mode" errors logged to the console.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment