New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Object.assign polyfill between UMD builds #10671

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@gaearon
Member

gaearon commented Sep 11, 2017

This wins back 0.3k post min/gzip which we lost due to adding license headers 馃槢 We can later share more utilities like this, since currently it's suboptimal that some fbjs things are duplicated. This only affects UMD builds.

How I verified it works:

It only affects UMD builds and doesn鈥檛 affect any other builds.
This is not global shared state, it's just manual deduplication.

@gaearon gaearon requested review from sophiebits, sebmarkbage and trueadm Sep 11, 2017

@gaearon gaearon referenced this pull request Sep 11, 2017

Closed

Flat Bundle Followup Umbrella #9321

19 of 23 tasks complete
@sophiebits

haha, ok

@gaearon gaearon merged commit f74981b into facebook:master Sep 11, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@bvaughn bvaughn referenced this pull request Sep 14, 2017

Closed

React 16 RC #10294

@gaearon gaearon deleted the gaearon:share-assign branch Sep 14, 2017

@gaearon gaearon referenced this pull request Apr 16, 2018

Merged

Support Pointer Events #12507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment