New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReactDOM.createPortal() official #10675

Merged
merged 2 commits into from Sep 11, 2017

Conversation

Projects
None yet
5 participants
@gaearon
Member

gaearon commented Sep 11, 2017

We might later want to move portal creation to React API that would be renderer-agnostic and work across renderers but it's likely that it will be a superset of the current API.

So we might as well call the current API "stable". Especially because it's the only migration path for top-level render returning null inside a batch in 16.

See individual commits. I added validation because otherwise you get a very confusing error when you pass something else. Also helps us make it clear it's currently not supported by SSR.

Open question: what happens if you do {isClient && ReactDOM.createPortal(...)}? Does it cause a mismatch on initial render? I don't know. Worth checking.

@gaearon gaearon requested review from sophiebits and flarnie Sep 11, 2017

@gaearon gaearon added this to the 16.0 milestone Sep 11, 2017

@gaearon gaearon requested a review from sebmarkbage Sep 11, 2017

@gaearon gaearon referenced this pull request Sep 11, 2017

Closed

React 16 Umbrella ☂️ (and 15.5) #8854

117 of 120 tasks complete

@gaearon gaearon merged commit 89508f2 into facebook:master Sep 11, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@gaearon gaearon deleted the gaearon:portal-stuff branch Sep 11, 2017

@koba04 koba04 referenced this pull request Sep 12, 2017

Closed

React 16 RC #10294

@eliseumds eliseumds referenced this pull request Sep 12, 2017

Closed

Rewrite V4 for React 16 #157

@thysultan thysultan referenced this pull request Sep 12, 2017

Merged

DIO 8 #28

@ntucker

This comment has been minimized.

Show comment
Hide comment
@ntucker

ntucker Sep 13, 2017

Is there documentation on this anywhere?

ntucker commented Sep 13, 2017

Is there documentation on this anywhere?

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Sep 13, 2017

Member

There will be. :-)

Member

gaearon commented Sep 13, 2017

There will be. :-)

@Slapbox

This comment has been minimized.

Show comment
Hide comment
@Slapbox

Slapbox Sep 24, 2017

@gaearon Do you have a rough idea of when the documentation will be available? A week? A month?

Thanks very much!

Slapbox commented Sep 24, 2017

@gaearon Do you have a rough idea of when the documentation will be available? A week? A month?

Thanks very much!

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Sep 24, 2017

Member

Together with React 16, in a few days. We provide documentation for new features at the same time they are released.

Member

gaearon commented Sep 24, 2017

Together with React 16, in a few days. We provide documentation for new features at the same time they are released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment