New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undocumented TestUtils methods #10681

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@gaearon
Member

gaearon commented Sep 12, 2017

These methods are not documented. Internally there's just one match of isCompositeComponentElement which is trivial to inline. The other two methods are not used internally, and have been broken in all 16 betas and RCs.

Enzyme technically imports them but doesn’t use. They don’t want to remove them until we remove them (airbnb/enzyme#1023). So let’s just remove before 16.

@gaearon gaearon merged commit 18d6cb5 into facebook:master Sep 12, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details

danseethaler added a commit to danseethaler/react that referenced this pull request Sep 13, 2017

danseethaler added a commit to danseethaler/react that referenced this pull request Sep 13, 2017

danseethaler added a commit to danseethaler/react that referenced this pull request Sep 13, 2017

@bvaughn bvaughn referenced this pull request Sep 14, 2017

Closed

React 16 RC #10294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment