Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive SVG hydration warning for mixed case tags #11174

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 10, 2017

Fixes #10772.

I opted for the fix suggested by @webcarrot in #10772 (comment).

It seems like the easiest and I don’t see a realistic situation in which it wouldn’t work. I guess it could break if you rendered <femorphology> on the server but <feMorphology> on the client, but who would possibly do that?

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 10, 2017

@sebmarkbage

@gaearon gaearon mentioned this pull request Oct 10, 2017
19 tasks
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. We are assuming that any other incorrect casing would not work as expected and therefore would get fixed.

@gaearon gaearon merged commit f42dfcd into facebook:master Oct 10, 2017
@gaearon gaearon deleted the svg-bugfix branch October 10, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected SSR difference warning with SVG <filter> primitives
3 participants