Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop Haste #11303
Not sure how I feel about this.
This helps enforce that we have proper module boundaries between packages. It already exposes some renderers read directly from reconciler (and thus won't be accessible to third party renderers). So I think that is kind of nice.
This exposed an interesting issue with Jest and Yarn Workspaces (facebook/jest#3830).
In a test,
This seemed like a show stopper to me at first. But then I thought, we don't like tests that do
In this case, you'd have to write
We could also wait for Jest to fix it but I doubt that will happen soon since almost nobody else bumped into this.
Mostly seeking feedback if anyone has strong objections at this point. If not, I could further flatten the structure, forbid relative requires in tests, and then fix the build. I expect that Rollup configuration will be significantly simpler now that we can let it use Node resolving mechanism without silly whitelists like:
referenced this pull request
Oct 22, 2017
This is a pretty large change-set. I skimmed it, paying more attention to the bits in
I also did a build-and-sync locally and ran Catalyst with it for a couple of minutes. Had to update
ReactNative.js to point to the new haste module name (
ReactNativeRenderer-*) but otherwise it seemed...ok. (I would expect this sort of change to fail fast and hard, if it broke things.)
Left a couple of minor thoughts. Overall this looks like a nice cleanup.