-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ReactFiberTreeReflection to react-reconciler/reflection #11683
Conversation
@@ -10,7 +10,8 @@ | |||
"fbjs": "^0.8.16", | |||
"object-assign": "^4.1.1", | |||
"prop-types": "^15.6.0", | |||
"regenerator-runtime": "^0.11.0" | |||
"regenerator-runtime": "^0.11.0", | |||
"react-reconciler": "^0.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our release script probably won't know to bump it, so eventually the local version will stop satisfying it. Can we use "*"
as a version instead? Since we never publish it, that should be enough as a workaround.
// Private. Used only by fixtures/fiber-debugger. | ||
ReactFiberInstrumentation, | ||
}, | ||
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just remove this field for now then.
|
||
'use strict'; | ||
|
||
export * from './src/ReactFiberTreeReflection'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a require
here for consistency with other top level entry points?
i.e.
module.exports = require('./src/ReactFiberTreeReflection');
We can eventually change this but I'd like all entry points to look the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, I see why this wouldn't work now.
thanks for the review! Yes i notice the require consistency but i find export to be a more easy and neat way to handle~ |
Could you please rebase on master and then re-run |
We don't know the latest local version, and release script currently doesn't bump deps automatically.
I didn't realize it would break the build.
Never mind, I'm doing it now. |
They're unnecessary now that we run real tests on reconciler bundles.
This was great. Thank you so much! |
welcome! |
* Move ReactFiberTreeReflection to react-reconciler/reflection #11659 * Use * for react-reconciler We don't know the latest local version, and release script currently doesn't bump deps automatically. * Remove unused field * Use CommonJS in entry point for consistency * Undo the CommonJS change I didn't realize it would break the build. * Record sizes * Remove reconciler fixtures They're unnecessary now that we run real tests on reconciler bundles.
ref #11659