New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReactFiberTreeReflection to react-reconciler/reflection #11683

Merged
merged 7 commits into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@rivenhk
Contributor

rivenhk commented Nov 28, 2017

ref #11659

'use strict';
export * from './src/ReactFiberTreeReflection';

This comment has been minimized.

@gaearon

gaearon Nov 28, 2017

Member

Can we use a require here for consistency with other top level entry points?
i.e.

module.exports = require('./src/ReactFiberTreeReflection');

We can eventually change this but I'd like all entry points to look the same.

@gaearon

gaearon Nov 28, 2017

Member

Can we use a require here for consistency with other top level entry points?
i.e.

module.exports = require('./src/ReactFiberTreeReflection');

We can eventually change this but I'd like all entry points to look the same.

This comment has been minimized.

@gaearon

gaearon Nov 28, 2017

Member

Nvm, I see why this wouldn't work now.

@gaearon

gaearon Nov 28, 2017

Member

Nvm, I see why this wouldn't work now.

@rivenhk

This comment has been minimized.

Show comment
Hide comment
@rivenhk

rivenhk Nov 28, 2017

Contributor

thanks for the review! Yes i notice the require consistency but i find export to be a more easy and neat way to handle~

Contributor

rivenhk commented Nov 28, 2017

thanks for the review! Yes i notice the require consistency but i find export to be a more easy and neat way to handle~

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 28, 2017

Member

Could you please rebase on master and then re-run yarn build to update JSON file with build stats?

Member

gaearon commented Nov 28, 2017

Could you please rebase on master and then re-run yarn build to update JSON file with build stats?

rivenhk and others added some commits Nov 28, 2017

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 28, 2017

Member

Never mind, I'm doing it now.

Member

gaearon commented Nov 28, 2017

Never mind, I'm doing it now.

Remove reconciler fixtures
They're unnecessary now that we run real tests on reconciler bundles.

@gaearon gaearon merged commit 8e876d2 into facebook:master Nov 28, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 28, 2017

Member

This was great. Thank you so much!

Member

gaearon commented Nov 28, 2017

This was great. Thank you so much!

@rivenhk

This comment has been minimized.

Show comment
Hide comment
@rivenhk

rivenhk Nov 28, 2017

Contributor

welcome!

Contributor

rivenhk commented Nov 28, 2017

welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment