Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify integration for DOM Fixtures folder #12350

Merged
merged 1 commit into from May 20, 2018

Conversation

@klamping
Copy link
Contributor

klamping commented Mar 9, 2018

In issue #11079, @nhunzaker mentions that it would be nice to have an automatic deployment of the DOM Fixtures folder for manual and automated testing purposes.

Since Netlify offers their services for free to open source projects (an account for this will need to be set up), I thought it would be a great fit.

This commit adds a netlify.toml file to the repo, allowing easier deployment out to the service.

This file will do two things:

  1. On master branch update, it deploys the latest code to the main linked netlify site. For example: https://musing-lewin-a6efa4.netlify.com/
  2. For every PR opened, creates a 'Deploy Preview' site for validating that PR's changes. For example: https://deploy-preview-1--musing-lewin-a6efa4.netlify.com/
    The preview site is linked via GitHub in the PR.
    image

Test Plan:
Create a Netlify account and connect the github repo you're testing to it.
After connection, Netlify should deploy the DOM fixtures build folder to a live site for you to use.

@aweary

This comment has been minimized.

Copy link
Member

aweary commented Mar 12, 2018

This is very cool, thank you for doing this @klamping! The React website is powered by Netlify, so we may already have an official account. cc @gaearon

@nhunzaker

This comment has been minimized.

Copy link
Collaborator

nhunzaker commented Mar 12, 2018

Wow. This is so cool; thank you so much!!

Let's get the account stuff setup!

@jquense

This comment has been minimized.

Copy link
Collaborator

jquense commented Mar 12, 2018

awesome!

@klamping klamping force-pushed the klamping:master branch from 1d0a0f9 to 83c024a Mar 30, 2018
@klamping

This comment has been minimized.

Copy link
Contributor Author

klamping commented Apr 17, 2018

Any chance I can get an update on the status of this?

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented May 4, 2018

@klamping Hey sorry for no response, we're pretty swamped by some longer term projects and so everything related to infra like testing is on a backburner. We really appreciate the PR but realistically we don't have enough time to review DOM-related changes either so it's not urgent to get in. When we get closer to working on these changes, we'll definitely check it out. Thanks!

@klamping

This comment has been minimized.

Copy link
Contributor Author

klamping commented May 18, 2018

@gaearon thanks for getting back with me and the explanation on it all!

@gaearon gaearon merged commit 089d2de into facebook:master May 20, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
TejasQ added a commit to TejasQ/react that referenced this pull request Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.