Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpful message when passing an element to createElement() #13131

Merged
merged 10 commits into from Aug 1, 2018
Merged

More helpful message when passing an element to createElement() #13131

merged 10 commits into from Aug 1, 2018

Conversation

@DCtheTall
Copy link
Contributor

@DCtheTall DCtheTall commented Jun 30, 2018

Fixes #13130

  • Added a more helpful message when someone passes an element to createElement in development.
@@ -327,7 +327,10 @@ export function createElementWithValidation(type, props, children) {
info += getStackAddendum() || '';

let typeString;
if (type === null) {
if (type && type.$$typeof) {
Copy link
Member

@gaearon gaearon Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this into the last else clause instead?
Also let's make the check more concrete, e.g. type.hasOwnPropery('$$typeof').

Loading

Copy link
Contributor Author

@DCtheTall DCtheTall Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely will use hasOwnProperty over dot notation.

Just to be clear, are you saying to nest another if statement inside that last else clause or make this the last else if before the else below?

Loading

Copy link
Contributor Author

@DCtheTall DCtheTall Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go with the latter to avoid any nested if statements (ugly). If you want it the other way just lmk.

Loading

@gaearon
Copy link
Member

@gaearon gaearon commented Jul 17, 2018

This will need tests too ;-)

Loading

@@ -333,6 +333,10 @@ export function createElementWithValidation(type, props, children) {
typeString = 'array';
} else {
typeString = typeof type;
if (type && type.hasOwnProperty('$$typeof')) {
typeString = 'element';
Copy link
Member

@gaearon gaearon Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"React element" would be better here.

Also now that I think of it let's compare type.$$typeof === REACT_ELEMENT_TYPE explicitly. We don't actually "own" this convention. You can get REACT_ELEMENT_TYPE from existing ReactSymbols import in this file.

Loading

@DCtheTall
Copy link
Contributor Author

@DCtheTall DCtheTall commented Aug 1, 2018

@gaearon totally understand you're a busy guy and this is probably a low priority PR, just wondering if there is anything I need to do on my end to get this ready for merge

Loading

@gaearon
Copy link
Member

@gaearon gaearon commented Aug 1, 2018

Been on a vacation :-) Checking it out.

Loading

@gaearon
Copy link
Member

@gaearon gaearon commented Aug 1, 2018

Made a few tweaks. Thanks!

Loading

@gaearon gaearon changed the title [#13130] More helpful message when passing an element to createElement() More helpful message when passing an element to createElement() Aug 1, 2018
@gaearon gaearon merged commit c44c2a2 into facebook:master Aug 1, 2018
1 check was pending
Loading
segoddnja added a commit to segoddnja/react that referenced this issue Aug 1, 2018
…book#13131)

* [facebook#13130] Add a more helpful message when passing an element to createElement()

* better conditional flow

* update after review

* move last condition inside last else clause

* Added test case

* compare 25132typeof to REACT_ELEMENT_TYPE

* runs prettier

* remove unrelated changes

* Tweak the message
TejasQ pushed a commit to TejasQ/react that referenced this issue Aug 26, 2018
…book#13131)

* [facebook#13130] Add a more helpful message when passing an element to createElement()

* better conditional flow

* update after review

* move last condition inside last else clause

* Added test case

* compare 25132typeof to REACT_ELEMENT_TYPE

* runs prettier

* remove unrelated changes

* Tweak the message
@gaearon gaearon mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants