Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodejs 10 to windows test #13241

Merged
merged 2 commits into from Aug 2, 2018

Conversation

@gengjiawen
Copy link
Contributor

gengjiawen commented Jul 19, 2018

No description provided.

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Aug 1, 2018

Let's just use 10? We don't want Windows CI to be slow, and in general we mainly support development on latest versions.

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

gengjiawen commented Aug 1, 2018

@gaearon done.

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Aug 1, 2018

Forgot to push?

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

gengjiawen commented Aug 2, 2018

pushed to the wrong branch, sorry :)

@gaearon gaearon merged commit d79238f into facebook:master Aug 2, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Aug 2, 2018

Thanks

TejasQ added a commit to TejasQ/react that referenced this pull request Aug 26, 2018
* add nodejs 10 to windows test

* remove node 8 for better build speed
iyegoroff added a commit to iyegoroff/react that referenced this pull request Mar 9, 2019
* add nodejs 10 to windows test

* remove node 8 for better build speed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.