-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors thrown in gDSFP of a module-style context provider #13269
Handle errors thrown in gDSFP of a module-style context provider #13269
Conversation
Context should be pushed before calling any user code, so if it errors the stack unwinds correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Test is clear. 👍 for whatever it's worth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Is it? Seems like the opposite to me |
@acdlite Just pieces I don't interact with much. Fun to see how this stuff works. |
…ebook#13269) Context should be pushed before calling any user code, so if it errors the stack unwinds correctly.
Context should be pushed before calling any user code, so if it errors the stack unwinds correctly.