Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors thrown in gDSFP of a module-style context provider #13269

Conversation

@acdlite
Copy link
Member

@acdlite acdlite commented Jul 25, 2018

Context should be pushed before calling any user code, so if it errors the stack unwinds correctly.

Context should be pushed before calling any user code, so if it errors
the stack unwinds correctly.
Copy link
Contributor

@nhunzaker nhunzaker left a comment

Interesting. Test is clear. 👍 for whatever it's worth.

Loading

Copy link
Contributor

@bvaughn bvaughn left a comment

Nice.

Loading

@acdlite acdlite merged commit bc1ea9c into facebook:master Jul 25, 2018
1 check was pending
Loading
@acdlite
Copy link
Member Author

@acdlite acdlite commented Jul 25, 2018

@nhunzaker

Interesting.

Is it? Seems like the opposite to me

Loading

@nhunzaker
Copy link
Contributor

@nhunzaker nhunzaker commented Jul 25, 2018

@acdlite Just pieces I don't interact with much. Fun to see how this stuff works.

Loading

segoddnja added a commit to segoddnja/react that referenced this issue Aug 1, 2018
…ebook#13269)

Context should be pushed before calling any user code, so if it errors
the stack unwinds correctly.
TejasQ pushed a commit to TejasQ/react that referenced this issue Aug 26, 2018
…ebook#13269)

Context should be pushed before calling any user code, so if it errors
the stack unwinds correctly.
@gaearon gaearon mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants