-
Notifications
You must be signed in to change notification settings - Fork 47.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat focusable as enumerated boolean SVG attribute #13339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the attribute table need to be updated?
What does this change do to the attribute table? Particularly, we should confirm that any change came with a warning before this change. |
Yep. Pushed. |
Fixes #12481.
It's a small behavior change but the old behavior both had a warning (in which case we don't provide strong guarantees) and was inconsistent with other similar attributes. The old behavior was also unintuitive.
Particularly, this relaxes the restriction on
<svg focusable>
to accept booleans. It's an enumerated attribute with'true'
,'false'
, and'auto'
values. This makes it consistent with how we already handle the HTMLdraggable
attribute (which also has'true'
,'false'
, and'auto'
values).Before:
After:
There's no behavior change for cases that didn't warn.
I couldn't find other attributes like this except
syncMaster
(which seems very niche?) so I'm not worried about this list growing.