Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TestUtils error messages for bad first argument #13351

Merged
merged 1 commit into from Aug 9, 2018

Conversation

@gaearon
Copy link
Member

@gaearon gaearon commented Aug 9, 2018

This makes errors like #11855 a bit clearer.
Don't think we'll want to support passing DOM nodes as it would require relying on more internals.

@pull-bot
Copy link

@pull-bot pull-bot commented Aug 9, 2018

Details of bundled changes.

Comparing: d59b993...9711aa9

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.development.js +2.3% +1.9% 43.74 KB 44.76 KB 11.9 KB 12.12 KB UMD_DEV
react-dom-test-utils.production.min.js 🔺+4.2% 🔺+3.8% 10.06 KB 10.48 KB 3.72 KB 3.86 KB UMD_PROD
react-dom-test-utils.development.js +2.3% +1.9% 43.46 KB 44.48 KB 11.84 KB 12.06 KB NODE_DEV
react-dom-test-utils.production.min.js 🔺+4.3% 🔺+3.4% 9.85 KB 10.28 KB 3.66 KB 3.79 KB NODE_PROD
ReactTestUtils-dev.js +2.5% +2.1% 40.66 KB 41.66 KB 10.92 KB 11.15 KB FB_WWW_DEV

Generated by 🚫 dangerJS

Loading

@gaearon gaearon merged commit 0072b59 into facebook:master Aug 9, 2018
1 check passed
Loading
@gaearon gaearon deleted the improve-scry-error branch Aug 9, 2018
@gaearon gaearon mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants