Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tangentialPressure and twist fields of pointer events #13374

Merged
merged 1 commit into from Aug 12, 2018
Merged

Support tangentialPressure and twist fields of pointer events #13374

merged 1 commit into from Aug 12, 2018

Conversation

@motiz88
Copy link
Contributor

@motiz88 motiz88 commented Aug 12, 2018

While working on facebook/flow#6728 I noticed React's recently-added SyntheticPointerEvent was missing the tangentialPressure and twist fields. I couldn't find any reason for their omission in #12507 (nor in the spec) so I assume they were meant to be included, like the rest of PointerEvent. This PR adds these two fields to SyntheticPointerEvent.

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Thanks for the PR! 🎉

This seems like an oversight on my end. Those properties are in the spec since 2016 - the oldest version I could find. I think we should support them as well. 👍

Loading

@philipp-spiess philipp-spiess merged commit ae855ce into facebook:master Aug 12, 2018
1 check passed
Loading
@motiz88 motiz88 deleted the pointer-event-fields branch Aug 12, 2018
motiz88 added a commit to motiz88/flow that referenced this issue Aug 12, 2018
facebook/react#13374 has been merged so the next
React DOM release will have these fields.
motiz88 added a commit to motiz88/flow that referenced this issue Aug 12, 2018
facebook/react#13374 has been merged so the next
React DOM release will have these fields.
TejasQ pushed a commit to TejasQ/react that referenced this issue Aug 26, 2018
…ok#13374)

While working on facebook/flow#6728 I noticed React's recently-added `SyntheticPointerEvent` was missing the [`tangentialPressure`](https://www.w3.org/TR/pointerevents/#dom-pointerevent-tangentialpressure) and [`twist`](https://www.w3.org/TR/pointerevents/#dom-pointerevent-twist) fields. I couldn't find any reason for their omission in facebook#12507 (nor in the spec) so I assume they were meant to be included, like the rest of `PointerEvent`. This PR adds these two fields to `SyntheticPointerEvent`.
facebook-github-bot added a commit to facebook/flow that referenced this issue Sep 5, 2018
Summary:
Closes #6373, closes #3227.

The definition of `SyntheticPointerEvent` here was originally based on facebook/react#12507 (released in React DOM 16.4.0) which was missing a couple of fields (`twist` and `tangentialPressure`) from the official spec.

I've now updated this branch to include those fields, since facebook/react#13374 has been merged. However, for maximum correctness we should probably wait for that to be _released_ before releasing the corresponding type definitions. I'll update this notice once the relevant React DOM release happens.
Pull Request resolved: #6728

Reviewed By: fishythefish

Differential Revision: D9338459

Pulled By: mrkev

fbshipit-source-id: 263f4922e8a6765e4a2d6553b5af785bdc65a894
@gaearon gaearon mentioned this pull request Sep 5, 2018
gaearon added a commit to reactjs/reactjs.org that referenced this issue Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants