Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume onSelect tracking after dragend #13422

Merged
merged 1 commit into from Aug 16, 2018
Merged

Conversation

@gaearon
Copy link
Member

@gaearon gaearon commented Aug 16, 2018

Fixes #11379.
Verified by the following the original repro instructions (you need to use arrow keys).

Note that listening to drop wouldn't be sufficient because it isn't fired on cancelled drag events. So if you didn't end up dropping, you'd still stop getting select events. By listening to dragend we handle both successful and unsuccessful drop cases.

Copy link
Collaborator

@sophiebits sophiebits left a comment

seemsreasonable

Loading

@gaearon gaearon merged commit d14e443 into facebook:master Aug 16, 2018
1 check was pending
Loading
@gaearon gaearon deleted the select-drop branch Aug 16, 2018
TejasQ pushed a commit to TejasQ/react that referenced this issue Aug 26, 2018
@gaearon gaearon mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants