Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Profiler onRender after mutations #13572

Merged

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 5, 2018

  • Don't call onRender until after mutations
  • Ensure commitTime reflects pre-mutation time
@pull-bot
Copy link

@pull-bot pull-bot commented Sep 5, 2018

ReactDOM: size: -0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 4e744be...48381b4

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.0% 0.0% 497.65 KB 497.58 KB 110.11 KB 110.14 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.0% -0.0% 214.75 KB 214.73 KB 37.45 KB 37.43 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.0% 0.0% 497.38 KB 497.31 KB 110.04 KB 110.08 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.0% -0.0% 204.57 KB 204.55 KB 35.8 KB 35.79 KB RN_OSS_PROD
ReactFabric-dev.js -0.0% 0.0% 487.83 KB 487.76 KB 107.69 KB 107.73 KB RN_FB_DEV
ReactFabric-prod.js -0.1% -0.1% 197.07 KB 196.93 KB 34.31 KB 34.29 KB RN_FB_PROD
ReactFabric-dev.js -0.0% 0.0% 487.87 KB 487.79 KB 107.71 KB 107.75 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% -0.0% 197.1 KB 196.97 KB 34.32 KB 34.3 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% -0.0% 211.68 KB 211.85 KB 37.14 KB 37.14 KB RN_OSS_PROFILING
ReactFabric-profiling.js +0.2% +0.2% 203.01 KB 203.5 KB 35.59 KB 35.65 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js +0.1% 0.0% 220.16 KB 220.33 KB 38.63 KB 38.63 KB RN_FB_PROFILING
ReactFabric-profiling.js +0.2% +0.2% 202.97 KB 203.46 KB 35.57 KB 35.63 KB RN_FB_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.0% 0.0% 644.92 KB 644.85 KB 151.12 KB 151.12 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 92.16 KB 92.16 KB 30.08 KB 30.07 KB UMD_PROD
react-dom.development.js -0.0% 0.0% 640.27 KB 640.19 KB 149.71 KB 149.72 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 92.1 KB 92.1 KB 29.67 KB 29.67 KB NODE_PROD
ReactDOM-dev.js -0.0% 0.0% 662.6 KB 662.52 KB 152.06 KB 152.06 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% -0.0% 286.89 KB 287.13 KB 53.15 KB 53.14 KB FB_WWW_PROD
react-dom.profiling.min.js 0.0% 0.0% 95.05 KB 95.05 KB 30.31 KB 30.31 KB NODE_PROFILING
ReactDOM-profiling.js +0.1% 0.0% 293.27 KB 293.69 KB 54.48 KB 54.48 KB FB_WWW_PROFILING

Generated by 🚫 dangerJS

Loading

acdlite
acdlite approved these changes Sep 5, 2018
@bvaughn bvaughn merged commit 550dd1d into facebook:master Sep 6, 2018
1 check passed
Loading
@bvaughn bvaughn deleted the call-Profiler-onRender-after-mutation branch Sep 6, 2018
@bvaughn bvaughn mentioned this pull request Sep 6, 2018
jetoneza added a commit to jetoneza/react that referenced this issue Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants