New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression related to isReactComponent prototype check #13608

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
5 participants
@gaearon
Member

gaearon commented Sep 10, 2018

Fixes #13580.

I didn't bother to add a warning since it would only point out legitimate problems for functional components that happen to have a prototype and isReactComponent on it... which seems like very low probability. So we might as well allow shadowing.

@pull-bot

This comment has been minimized.

pull-bot commented Sep 10, 2018

Details of bundled changes.

Comparing: 03ab1ef...64c4e73

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@aweary

aweary approved these changes Sep 10, 2018

@gaearon gaearon merged commit 4a40d76 into facebook:master Sep 10, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@gaearon gaearon referenced this pull request Sep 13, 2018

Merged

Add 16.5.1 changelog #13638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment