Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable_ prefix from Suspense #13922

Merged
merged 1 commit into from Oct 23, 2018

Conversation

@sebmarkbage
Copy link
Member

@sebmarkbage sebmarkbage commented Oct 23, 2018

We are using it with lazy and the combination Suspense + lazy seems pretty stable. maxDuration is not but that's only enabled when you're in ConcurrentMode which is still unstable.

Don't forget to fix www.

We are using it with lazy and the combination Suspense + lazy seems pretty
stable. maxDuration is not but that's only enabled when you're in
ConcurrentMode which is still unstable.
@sebmarkbage
Copy link
Member Author

@sebmarkbage sebmarkbage commented Oct 23, 2018

Although I guess #13921 is a counter argument. :)

@gaearon
Copy link
Member

@gaearon gaearon commented Oct 23, 2018

Would be nice to follow up to understand how it landed while breaking that test.

@sophiebits
Copy link
Collaborator

@sophiebits sophiebits commented Oct 23, 2018

Should maxDuration be prefixed?

@sebmarkbage
Copy link
Member Author

@sebmarkbage sebmarkbage commented Oct 23, 2018

I think it's fine to leave maxDuration. You have to type unstable_ somewhere to use it. We're going to have to add types for this API and changing that after the fact, especially with the poor versioning story there, it'll be a pain.

@sebmarkbage sebmarkbage merged commit d75c69e into facebook:master Oct 23, 2018
1 check was pending
1 check was pending
ci/circleci Your tests are queued behind your running builds
Details
@sizebot
Copy link

@sizebot sizebot commented Oct 23, 2018

Details of bundled changes.

Comparing: 04c4f2f...7d66f90

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

jetoneza added a commit to jetoneza/react that referenced this pull request Jan 23, 2019
We are using it with lazy and the combination Suspense + lazy seems pretty
stable. maxDuration is not but that's only enabled when you're in
ConcurrentMode which is still unstable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants