New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if number of hooks increases #14591

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
3 participants
@acdlite
Copy link
Member

acdlite commented Jan 15, 2019

Based on #14569

Eventually, we'll likely support adding hooks to the end (to enable progressive enhancement), but let's warn until we figure out how it should work.

@acdlite acdlite force-pushed the acdlite:no-append-hooks branch 2 times, most recently from 6ff5571 to e3e4f78 Jan 16, 2019

@acdlite acdlite closed this Jan 17, 2019

@acdlite acdlite force-pushed the acdlite:no-append-hooks branch from e3e4f78 to 790c8ef Jan 17, 2019

Warn if number of hooks increases
Eventually, we'll likely support adding hooks to the end (to enable
progressive enhancement), but let's warn until we figure out how it
should work.

@acdlite acdlite reopened this Jan 17, 2019

@acdlite acdlite merged commit 71b64d5 into facebook:master Jan 17, 2019

1 check was pending

ci/circleci CircleCI is running your tests
Details

jetoneza added a commit to jetoneza/react that referenced this pull request Jan 23, 2019

Warn if number of hooks increases (facebook#14591)
Eventually, we'll likely support adding hooks to the end (to enable
progressive enhancement), but let's warn until we figure out how it
should work.

n8schloss added a commit to n8schloss/react that referenced this pull request Jan 31, 2019

Warn if number of hooks increases (facebook#14591)
Eventually, we'll likely support adding hooks to the end (to enable
progressive enhancement), but let's warn until we figure out how it
should work.

Kiku-git added a commit to Kiku-git/react that referenced this pull request Feb 10, 2019

Warn if number of hooks increases (facebook#14591)
Eventually, we'll likely support adding hooks to the end (to enable
progressive enhancement), but let's warn until we figure out how it
should work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment