New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-render function components with Hooks in DEV in StrictMode #14654

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@gaearon
Copy link
Member

gaearon commented Jan 21, 2019

Reverts #14652

In case we want to get it in

@gaearon gaearon changed the title Resubmit "Double-render function components with Hooks in DEV in StrictMode" Double-render function components with Hooks in DEV in StrictMode Jan 22, 2019

@gaearon gaearon requested review from acdlite , bvaughn and sebmarkbage Jan 22, 2019

@bvaughn
Copy link
Contributor

bvaughn left a comment

I don't have an objection to this, considering it's DEV-only and only for components using hooks.

@gaearon gaearon merged commit 73962c3 into master Jan 23, 2019

1 check was pending

ci/circleci CircleCI is running your tests
Details
@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 23, 2019

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 9944392...89f93c6

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% 0.0% 739.07 KB 740.08 KB 170.55 KB 170.61 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 98.88 KB 98.88 KB 32.18 KB 32.18 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 101.86 KB 101.86 KB 32.83 KB 32.82 KB UMD_PROFILING
react-dom.development.js +0.1% 0.0% 734.13 KB 735.14 KB 169.12 KB 169.18 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 98.88 KB 98.88 KB 31.67 KB 31.67 KB NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 101.98 KB 101.98 KB 32.29 KB 32.29 KB NODE_PROFILING
ReactDOM-dev.js +0.2% +0.1% 756.7 KB 758.01 KB 170.36 KB 170.53 KB FB_WWW_DEV
react-dom-unstable-fire.development.js +0.1% 0.0% 739.42 KB 740.42 KB 170.69 KB 170.75 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% -0.0% 98.89 KB 98.89 KB 32.19 KB 32.18 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 101.88 KB 101.88 KB 32.83 KB 32.83 KB UMD_PROFILING
react-dom-unstable-fire.development.js +0.1% 0.0% 734.48 KB 735.48 KB 169.26 KB 169.33 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% -0.0% 98.9 KB 98.9 KB 31.68 KB 31.68 KB NODE_PROD
ReactFire-dev.js +0.2% +0.1% 755.91 KB 757.22 KB 170.31 KB 170.48 KB FB_WWW_DEV
ReactFire-prod.js 0.0% -0.0% 301.09 KB 301.09 KB 55.26 KB 55.26 KB FB_WWW_PROD
ReactFire-profiling.js 0.0% -0.0% 308.18 KB 308.18 KB 56.55 KB 56.55 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 44.87 KB 44.87 KB 12.3 KB 12.3 KB UMD_DEV
react-dom-test-utils.development.js 0.0% -0.0% 44.59 KB 44.59 KB 12.24 KB 12.24 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.61 KB 60.61 KB 15.92 KB 15.92 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 11.01 KB 11.01 KB 3.81 KB 3.81 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.29 KB 60.29 KB 15.79 KB 15.79 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.75 KB 10.75 KB 3.71 KB 3.71 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 125.09 KB 125.09 KB 33.35 KB 33.35 KB UMD_DEV
ReactDOMServer-dev.js 0.0% -0.0% 122.4 KB 122.4 KB 32.07 KB 32.07 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 45.18 KB 45.18 KB 10.4 KB 10.39 KB FB_WWW_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 17.74 KB 17.74 KB 6.83 KB 6.83 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.63 KB 3.63 KB 1.44 KB 1.44 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 707 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.45 KB 3.45 KB 1.39 KB 1.39 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.05 KB 1.05 KB 639 B 637 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.7 KB 3.7 KB 1.42 KB 1.42 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.1 KB 1.1 KB 669 B 667 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.2% +0.1% 517.92 KB 518.92 KB 114.39 KB 114.46 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 90.93 KB 90.93 KB 27.97 KB 27.97 KB UMD_PROD
react-art.development.js +0.2% +0.1% 449.44 KB 450.45 KB 97.27 KB 97.34 KB NODE_DEV
ReactART-dev.js +0.3% +0.2% 458.42 KB 459.73 KB 96.42 KB 96.59 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.2% +0.1% 582.92 KB 584.23 KB 126.97 KB 127.08 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% -0.0% 244.14 KB 244.14 KB 42.9 KB 42.9 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.2% +0.1% 582.83 KB 584.14 KB 126.93 KB 127.04 KB RN_OSS_DEV
ReactNativeRenderer-profiling.js 0.0% -0.0% 233.19 KB 233.19 KB 40.91 KB 40.91 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.2% +0.1% 573.77 KB 575.08 KB 124.7 KB 124.81 KB RN_FB_DEV
ReactFabric-prod.js 0.0% -0.0% 237.34 KB 237.34 KB 41.45 KB 41.45 KB RN_FB_PROD
ReactFabric-profiling.js 0.0% -0.0% 242.64 KB 242.64 KB 42.77 KB 42.77 KB RN_FB_PROFILING
ReactFabric-dev.js +0.2% +0.1% 573.68 KB 574.99 KB 124.66 KB 124.77 KB RN_OSS_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.2% +0.1% 462.66 KB 463.66 KB 100.03 KB 100.1 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 57.31 KB 57.31 KB 17.61 KB 17.61 KB UMD_PROD
react-test-renderer.development.js +0.2% +0.1% 457.62 KB 458.62 KB 98.8 KB 98.86 KB NODE_DEV
ReactTestRenderer-dev.js +0.3% +0.2% 466.81 KB 468.12 KB 98.29 KB 98.46 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 38.09 KB 38.09 KB 9.83 KB 9.83 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 10.56 KB 10.56 KB 3.25 KB 3.25 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 32.39 KB 32.39 KB 8.47 KB 8.46 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.2 KB 11.2 KB 3.49 KB 3.49 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.2% +0.1% 447.27 KB 448.28 KB 95.78 KB 95.84 KB NODE_DEV
react-reconciler.production.min.js 0.0% -0.0% 57.07 KB 57.07 KB 17.07 KB 17.07 KB NODE_PROD
react-reconciler-persistent.development.js +0.2% +0.1% 445.65 KB 446.65 KB 95.13 KB 95.19 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% -0.0% 57.08 KB 57.08 KB 17.07 KB 17.07 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% -0.0% 15.4 KB 15.4 KB 4.84 KB 4.83 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.56 KB 2.56 KB 1.13 KB 1.13 KB NODE_PROD

Generated by 🚫 dangerJS

@gaearon gaearon deleted the revert-14652-revert-14643-fun-sm-hooks branch Jan 23, 2019

n8schloss added a commit to n8schloss/react that referenced this pull request Jan 31, 2019

Kiku-git added a commit to Kiku-git/react that referenced this pull request Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment