Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coverage badge from README #15216

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@bvaughn
Copy link
Contributor

bvaughn commented Mar 26, 2019

This badge doesn't seem that useful. I'm also not really sure how it's being computed, given that the Coveralls report seems mostly comprised of .py files:
Screen Shot 2019-03-26 at 12 34 40 PM

FYI @paul (just on the off chance that you care)

@bvaughn bvaughn merged commit 0d5e4c7 into facebook:master Mar 26, 2019
1 check was pending
1 check was pending
ci/circleci Your tests are queued behind your running builds
Details
@bvaughn bvaughn deleted the bvaughn:remove-coverage-badge branch Mar 26, 2019
@paul

This comment has been minimized.

Copy link

paul commented Mar 26, 2019

I do not care.

@bvaughn

This comment has been minimized.

Copy link
Contributor Author

bvaughn commented Mar 26, 2019

Haha, sorry Paul! Auto complete got the best of me. I meant to cc @zpao.

@zpao

This comment has been minimized.

Copy link
Member

zpao commented Mar 28, 2019

I think you must be looking at a different coveralls report 😬. I see the react repo tree… it's not my call anyway though so y'all do you!

@bvaughn

This comment has been minimized.

Copy link
Contributor Author

bvaughn commented Mar 28, 2019

Interesting. The report has since changed. Andrew and I both looked at it previous, and the build date was very stale. (Now it shows March 2019, but before it showed a date several years ago.)

Oh well. 👍

@meals37

This comment has been minimized.

Copy link

meals37 commented Sep 4, 2019

God bless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.