Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReactDomEventListener #15271

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Imadra
Copy link

commented Mar 30, 2019

targetInst can be undefined, so check not if it is nonnull, but if it is truthy

@trueadm

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

Can you add a test case for where getClosestInstanceFromNode should return undefined. I believe the intention of getClosestInstanceFromNode was to always return null or a node so maybe this is a bug – thus a test would be good.

@cpojer

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@Imadra can you add the test case that @trueadm was asking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.