Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix areHookInputsEqual method warning params order #15345

Merged
merged 2 commits into from Apr 8, 2019

Conversation

@brickspert
Copy link
Contributor

commented Apr 7, 2019

Fix hooks areHookInputsEqual method warning params order

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 7, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 7, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

尽龙
@threepointone
Copy link
Contributor

left a comment

good catch! approving, will merge later in the week. thank you!

@threepointone threepointone merged commit b4bc33a into facebook:master Apr 8, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

Kiku-Reise added a commit to Kiku-Reise/react that referenced this pull request May 16, 2019

Fix areHookInputsEqual method warning params order (facebook#15345)
* Fix areHookInputsEqual method  warning params order

* FIX areHookInputsEqual test
@gaearon gaearon referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.