Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental event API: Focus module #15346

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@behzad888
Copy link
Contributor

commented Apr 7, 2019

Note:
determine eventData and pointerType

{
  pointerType: 'mouse' | 'pen' | 'touch' | 'keyboard'
}

Ref #15257

@sizebot

This comment has been minimized.

Copy link

commented Apr 7, 2019

Details of bundled changes.

Comparing: 81a61b1...e948baa

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% -0.2% 1.16 KB 1.16 KB 617 B 616 B UMD_DEV
react-events.production.min.js 0.0% 🔺+0.3% 512 B 512 B 352 B 353 B NODE_PROD
react-events-press.development.js 0.0% 0.0% 12.88 KB 12.88 KB 3.02 KB 3.02 KB UMD_DEV
react-events-hover.development.js 0.0% +0.1% 6.74 KB 6.74 KB 1.79 KB 1.79 KB UMD_DEV
react-events-hover.production.min.js 0.0% 🔺+0.1% 3.02 KB 3.02 KB 1.15 KB 1.15 KB UMD_PROD
react-events-hover.production.min.js 0.0% 🔺+0.1% 2.85 KB 2.85 KB 1.1 KB 1.1 KB NODE_PROD
react-events-focus.development.js +68.6% +73.4% 3.29 KB 5.54 KB 1.11 KB 1.92 KB UMD_DEV
react-events-focus.production.min.js 🔺+64.2% 🔺+61.6% 1.52 KB 2.49 KB 740 B 1.17 KB UMD_PROD
react-events-focus.development.js +72.4% +78.0% 3.12 KB 5.37 KB 1.06 KB 1.89 KB NODE_DEV
react-events-focus.production.min.js 🔺+72.4% 🔺+68.7% 1.35 KB 2.33 KB 670 B 1.1 KB NODE_PROD
ReactEventsFocus-dev.js +11.4% +5.9% 3.04 KB 3.38 KB 1.03 KB 1.1 KB FB_WWW_DEV
ReactEventsFocus-prod.js 🔺+21.0% 🔺+10.4% 2.36 KB 2.85 KB 809 B 893 B FB_WWW_PROD
react-events-swipe.development.js 0.0% -0.0% 8.29 KB 8.29 KB 2.57 KB 2.57 KB UMD_DEV
react-events-swipe.production.min.js 0.0% -0.1% 3.46 KB 3.46 KB 1.61 KB 1.61 KB UMD_PROD
react-events-swipe.production.min.js 0.0% -0.1% 3.29 KB 3.29 KB 1.55 KB 1.55 KB NODE_PROD
react-events-drag.production.min.js 0.0% -0.1% 3.3 KB 3.3 KB 1.5 KB 1.5 KB UMD_PROD
react-events-drag.production.min.js 0.0% -0.1% 3.14 KB 3.14 KB 1.44 KB 1.44 KB NODE_PROD

Generated by 🚫 dangerJS

@matthargett

This comment has been minimized.

Copy link

commented Apr 7, 2019

What about ‘gaze’ for AR/VR?l, and directional pad for TV remote/game controller?

@necolas

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

We're still figuring things out. Not sure it's worth your time submitting PRs for experimental APIs that are in flux.

@jhampton

This comment has been minimized.

Copy link

commented Apr 12, 2019

What about ‘gaze’ for AR/VR?l, and directional pad for TV remote/game controller?

Agreed @matthargett . At the risk of being a pedant, perhaps a dwell or hover could be an analog for the same intent?

@necolas

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Thanks for taking interest in this work. But I'm closing this PR as master has diverged quite a lot and we're still figuring out event data internally. This approach doesn't work either as native focus/blur events do not contain pointerType information on the event object.

@necolas necolas closed this Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.