Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the wrong renderer's act() should warn #15756

Merged
Commits on May 28, 2019
  1. warn when using the wrong renderer's act around another renderer's up…

    threepointone committed May 28, 2019
    …dates
    
    like it says. it uses a real object as the sigil (instead of just a boolean). specifically, it uses a renderer's flushPassiveEffects as the sigil. We also run tests for this separate from our main suite (which doesn't allow loading multiple renderers in a suite), but makes sure to run this in CI as well.
  2. unneeded (and wrong) comment

    threepointone committed May 28, 2019
  3. run the dom fixture on CI

    threepointone committed May 28, 2019
Commits on May 29, 2019
  1. update the sigil only in __DEV__

    threepointone committed May 29, 2019
  2. remove the obnoxious comment

    threepointone committed May 29, 2019
  3. use an explicit export for the sigil

    threepointone committed May 29, 2019
You can’t perform that action at this time.