unify deprecated/unsafe lifecycle warnings, pass tests #16103
This PR tweaks the deprecated/unsafe lifecycle warnings.
Things to do in future PRs asap -
Details of bundled changes.
bvaughn left a comment •
These lifecycles are actually deprecated and will be removed in the next major version. I think changing the message to "not recommended" is a mistake.
Edit for clarity I think it's okay to say
But I don't think it's good to say:
I think our warning needs to be more than just "not recommended" because the idea is that it will stop working in a future version.
trueadm left a comment •
The usage of the phrase
I think it's important we get this right, otherwise we're just going to cause pain for quite a large segment of users who are upgrading from an older version.