Reset didReceiveUpdate in beginWork #16359
Merged
Conversation
This is a bad bug. It means that we sometimes inherit didReceiveUpdate from a previous component's begin. Effectively this only means that we're overrendering in some cases. We should refactor to get rid of this as a global flag.
No significant bundle size changes to report.
Generated by |
Chatted offline. This is a bug but it only affects the hooks bailout optimization, and only if all of the following are true:
So it's pretty rare. I wrote a test case. I'll submit separately.
|
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Aug 12, 2019
A test case that hits this for Suspense is added in #16369 |
acdlite
added a commit
that referenced
this pull request
Aug 13, 2019
This was referenced Oct 5, 2019
This was referenced Apr 14, 2020
This was referenced Apr 21, 2020
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a bad bug. It means that we sometimes inherit
didReceiveUpdate from a previous component's begin.
Effectively this only means that we're overrendering in some cases.
We should refactor to get rid of this as a global flag.
I don’t have a test case because it only showed up as an intermediate state in another test. Maybe we can come up with something simplified.