Skip to content

/react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate sizebot for experimental builds #17100

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@acdlite
Copy link
Member

acdlite commented Oct 15, 2019

Configures the sizebot to leave a second comment that tracks the experimental build artifacts.
@acdlite acdlite force-pushed the acdlite:sizebot-experimental branch 4 times, most recently from 34c3ab3 to 8cbaf22 Oct 15, 2019
@sizebot

This comment has been minimized.

Sign in to view
Copy link

sizebot commented Oct 15, 2019 •
edited

Size changes (stable)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against d07d8b5

@sizebot

This comment has been minimized.

Sign in to view
Copy link

sizebot commented Oct 15, 2019 •
edited

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against d07d8b5

@acdlite acdlite force-pushed the acdlite:sizebot-experimental branch from 8cbaf22 to edec3e1 Oct 15, 2019
@facebook facebook deleted a comment from sizebot Oct 15, 2019
@acdlite acdlite force-pushed the acdlite:sizebot-experimental branch 2 times, most recently from dc887bf to 4f77d81 Oct 15, 2019
@acdlite acdlite marked this pull request as ready for review Oct 15, 2019
@acdlite acdlite requested review from sebmarkbage, bvaughn, gaearon and trueadm Oct 15, 2019
@acdlite
Separate sizebot for experimental builds
Loading status checks…
d07d8b5 
Configures the sizebot to leave a second comment that tracks the
experimental build artifacts.
@acdlite acdlite force-pushed the acdlite:sizebot-experimental branch from 4f77d81 to d07d8b5 Oct 15, 2019
@sebmarkbage
sebmarkbage approved these changes Oct 16, 2019
View changes
@sebmarkbage

This comment has been minimized.

Sign in to view
Copy link
Member

sebmarkbage commented Oct 16, 2019

Alternatively do a fan-in work flow thingy.
@acdlite acdlite merged commit 2c832b4 into facebook:master Oct 16, 2019
20 checks passed
20 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage

@bvaughn bvaughn

@gaearon gaearon

@trueadm trueadm

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
4 participants
@acdlite @sizebot @sebmarkbage @facebook-github-bot
You can’t perform that action at this time.