Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script should default to experimental #17144

Merged
merged 1 commit into from Oct 19, 2019

Conversation

@acdlite
Copy link
Member

acdlite commented Oct 18, 2019

yarn build defaults to building in experimental mode. To opt-out, set the RELEASE_CHANNEL environment variable to stable. This is the same as what we do when running tests via yarn test, to make local development easier.

`yarn build` defaults to building in experimental mode. To opt-out, set
the `RELEASE_CHANNEL` environment variable to `stable`. This is the same
as what we do when running tests via `yarn test`, to make local
development easier.
@acdlite acdlite requested a review from sebmarkbage Oct 18, 2019
@acdlite acdlite force-pushed the acdlite:yarn-build-default-experimental branch from 5e1287a to e3dbf12 Oct 18, 2019
@sizebot

This comment has been minimized.

Copy link

sizebot commented Oct 18, 2019

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against e3dbf12

@sizebot

This comment has been minimized.

Copy link

sizebot commented Oct 18, 2019

Size changes (stable)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against e3dbf12

@sebmarkbage

This comment has been minimized.

Copy link
Member

sebmarkbage commented Oct 19, 2019

Does this affect the release script in anyway? E.g. does it make us release experimental builds by default?

@acdlite

This comment has been minimized.

Copy link
Member Author

acdlite commented Oct 19, 2019

No, the release script pulls from CI artifacts. It doesn’t build locally.

Additionally, stable releases must be promoted from a canary, and the prepare-stable script will exit if you try to promote an experimental one.

So you would have to intentionally circumvent the normal release process in order to mess it up.

@acdlite acdlite merged commit edc234c into facebook:master Oct 19, 2019
20 checks passed
20 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.