Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .mailmap #17177

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@terabaud
Copy link
Contributor

terabaud commented Oct 24, 2019

Update authors due to name change.

@sizebot

This comment has been minimized.

Copy link

sizebot commented Oct 24, 2019

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 4f060d3

@sizebot

This comment has been minimized.

Copy link

sizebot commented Oct 24, 2019

Size changes (stable)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 4f060d3

@threepointone

This comment has been minimized.

Copy link
Contributor

threepointone commented Oct 27, 2019

Sorry if I don’t understand, but what does this change? It seems to be an addition, hence I’m curious.

Additionally, do you think we should verify this list across the repo’s history, with a script or something

@terabaud

This comment has been minimized.

Copy link
Contributor Author

terabaud commented Oct 28, 2019

I am mtf trans and there is one problem: before my transition, I contributed to React, so that my deadname appears in the AUTHORS file of this repository (L___ Rosema).

The AUTHORS file is auto generated from a script using the git history:
https://github.com/facebook/react/blob/master/scripts/authors

See also: git shortlog

For my past (and future) contributions to React, I'd like my deadname from the AUTHORS file to be removed and replaced by my proper name and email adress.

The .mailmap file is used for these overrides.

@threepointone threepointone merged commit 0f64703 into facebook:master Oct 28, 2019
20 checks passed
20 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
@threepointone

This comment has been minimized.

Copy link
Contributor

threepointone commented Oct 28, 2019

Thank you for the details! I’ve merged the PR, please do let me know if there’s anything else I can do.

@aweary

This comment has been minimized.

Copy link
Member

aweary commented Oct 28, 2019

Hey @terabaud, we don't really run the script to update AUTHORS very frequently. Please feel free to submit a PR that manually removes your deadname from the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.