Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webpack as devDependency #17379

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@sebmarkbage
Copy link
Member

sebmarkbage commented Nov 15, 2019

Follow up to #17372

This is now used by the Flight package so it needs to be installed as a peer.

This is now used by the Flight package so it needs to be installed as a
peer.
@sebmarkbage sebmarkbage requested a review from acdlite Nov 15, 2019
@sebmarkbage sebmarkbage requested review from bvaughn and gaearon Nov 15, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Nov 15, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f23612:

Sandbox Source
spring-bird-prb97 Configuration
@sizebot

This comment has been minimized.

Copy link

sizebot commented Nov 15, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 0f23612

@sizebot

This comment has been minimized.

Copy link

sizebot commented Nov 15, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 0f23612

@sebmarkbage sebmarkbage merged commit 8e74a31 into facebook:master Nov 15, 2019
21 checks passed
21 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.