Skip to content

/react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on local git checkout from build process #17475

Merged
merged 2 commits into from Nov 27, 2019

Conversation

@bvaughn
Copy link
Contributor

bvaughn commented Nov 27, 2019

Update build steps so Mozilla reviewers can build DevTools from local Git archive without an error:

  • Remove unnecessary build-time parsing of GitHub URL now that the project has been migrated to the main React repo.
  • Try/catch guard around Git revision parsing to avoid build failure.

Also updated the Webpack dependencies to account for changes made in #17379
bvaughn added 2 commits Nov 27, 2019
@bvaughn
Remove dependency on local git checkout from build process
5231739
@bvaughn
Updated Webpack dependencies to account for recent changes to deps fo…
Loading status checks…
6afd47e 
…r Flight
@bvaughn bvaughn requested review from threepointone and lunaruan Nov 27, 2019
@bvaughn bvaughn force-pushed the bvaughn:issues/17409 branch from 19734fe to 6afd47e Nov 27, 2019
@threepointone
threepointone approved these changes Nov 27, 2019
View changes
@codesandbox

This comment has been minimized.

Sign in to view
Copy link

codesandbox bot commented Nov 27, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6afd47e:

Sandbox Source
unruffled-almeida-ee1gu Configuration
@sizebot

This comment has been minimized.

Sign in to view
Copy link

sizebot commented Nov 27, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 6afd47e

@sizebot

This comment has been minimized.

Sign in to view
Copy link

sizebot commented Nov 27, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 6afd47e

@bvaughn bvaughn mentioned this pull request Nov 27, 2019
Closed
@bvaughn bvaughn merged commit 5fc9742 into facebook:master Nov 27, 2019
21 checks passed
21 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@bvaughn bvaughn deleted the bvaughn:issues/17409 branch Nov 27, 2019
trueadm added a commit to trueadm/react that referenced this pull request Dec 4, 2019
@bvaughn @trueadm
Remove dependency on local git checkout from build process (facebook#…
9b040f1 
…17475)

* Remove dependency on local git checkout from build process

* Updated Webpack dependencies to account for recent changes to deps for Flight
trueadm added a commit to trueadm/react that referenced this pull request Dec 4, 2019
@bvaughn @trueadm
Remove dependency on local git checkout from build process (facebook#…
022a1e0 
…17475)

* Remove dependency on local git checkout from build process

* Updated Webpack dependencies to account for recent changes to deps for Flight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone

@lunaruan lunaruan

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
4 participants
@bvaughn @sizebot @threepointone @facebook-github-bot
You can’t perform that action at this time.