Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and store DevTools artifacts in Circle CI #17746

Merged

Conversation

@bvaughn
Copy link
Contributor

bvaughn commented Dec 30, 2019

Might as well leverage Circle CI to test our DevTools builds, and if we're doing that- we might as well store the artifacts as well. Maybe in the future, we should release DevTools directly from CI artifacts as well, like we do for NPM packages.

Let's see if these changes actually work... 馃槃

@bvaughn bvaughn requested review from gaearon and acdlite Dec 30, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd76991:

Sandbox Source
agitated-aryabhata-idpr7 Configuration
Copy link
Contributor

threepointone left a comment

Preemptive stamp

@sizebot

This comment has been minimized.

Copy link

sizebot commented Dec 30, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 馃毇 dangerJS against cd76991

@sizebot

This comment has been minimized.

Copy link

sizebot commented Dec 30, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 馃毇 dangerJS against cd76991

@bvaughn bvaughn force-pushed the bvaughn:circle-ci-store-devtools-artifacts branch 2 times, most recently from 5889930 to 1f5f2e5 Dec 31, 2019
@bvaughn

This comment has been minimized.

Copy link
Contributor Author

bvaughn commented Dec 31, 2019

I think Circle CI is confused. Looks like it re-ran part of the build commands without cleaning up, so now some things are failing b'c files are left over from previous runs. I used to have the option to clear cache and re-run but I don't see it anymore.

@bvaughn bvaughn force-pushed the bvaughn:circle-ci-store-devtools-artifacts branch from aa577a8 to 756dfc9 Dec 31, 2019
@bvaughn bvaughn force-pushed the bvaughn:circle-ci-store-devtools-artifacts branch from 756dfc9 to cd76991 Dec 31, 2019
@bvaughn

This comment has been minimized.

Copy link
Contributor Author

bvaughn commented Jan 1, 2020

Yay Circle CI seems to have finally passed after the last round of changes.

@bvaughn bvaughn merged commit 2c1e5d2 into facebook:master Jan 1, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@bvaughn bvaughn deleted the bvaughn:circle-ci-store-devtools-artifacts branch Jan 1, 2020
@xusai2014

This comment has been minimized.

Copy link

xusai2014 commented Jan 2, 2020

Might as well leverage Circle CI to test our DevTools builds, and if we're doing that- we might as well store the artifacts as well. Maybe in the future, we should release DevTools directly from CI artifacts as well, like we do for NPM packages.

Let's see if these changes actually work... 馃槃

Hi Guys

Your ideas appeal to me. Could you describe the detail of the ideas锛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.