Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React.createFactory() deprecation warning #17878

Merged
merged 1 commit into from Jan 21, 2020

Conversation

trueadm
Copy link
Member

@trueadm trueadm commented Jan 21, 2020

This PR adds a deprecation warning when React.createFactory is used in DEV. This is a follow up to the comment in #17873 (comment).

The warning is as follows:

Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43e41b6:

Sandbox Source
cool-sanderson-b9496 Configuration

@sizebot
Copy link

sizebot commented Jan 21, 2020

Details of bundled changes.

Comparing: 0c04aca...43e41b6

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.3% +0.2% 112.49 KB 112.82 KB 28.78 KB 28.83 KB UMD_DEV
react.production.min.js 0.0% 0.0% 12.33 KB 12.33 KB 4.84 KB 4.84 KB UMD_PROD
react.profiling.min.js 0.0% 0.0% 15.85 KB 15.85 KB 5.95 KB 5.95 KB UMD_PROFILING
react.development.js +0.4% +0.3% 72.01 KB 72.33 KB 19.11 KB 19.16 KB NODE_DEV
react.production.min.js 0.0% 0.0% 6.54 KB 6.54 KB 2.72 KB 2.72 KB NODE_PROD

React: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 43e41b6

@sizebot
Copy link

sizebot commented Jan 21, 2020

Details of bundled changes.

Comparing: 0c04aca...43e41b6

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.3% +0.2% 112.52 KB 112.84 KB 28.78 KB 28.84 KB UMD_DEV
react.production.min.js 0.0% 0.0% 12.67 KB 12.67 KB 4.94 KB 4.95 KB UMD_PROD
react.profiling.min.js 0.0% 0.0% 16.2 KB 16.2 KB 6.05 KB 6.05 KB UMD_PROFILING
react.development.js +0.4% +0.3% 72.03 KB 72.35 KB 19.11 KB 19.17 KB NODE_DEV
react.production.min.js 0.0% 0.0% 6.96 KB 6.96 KB 2.86 KB 2.86 KB NODE_PROD
React-dev.js +0.5% +0.4% 72.26 KB 72.62 KB 18.4 KB 18.46 KB FB_WWW_DEV

React: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 43e41b6

@trueadm trueadm force-pushed the create-factory-warning branch from ed61c10 to 43e41b6 Compare Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants