Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dom fixture for autofilled form state #17951

Merged
merged 1 commit into from Feb 4, 2020

Conversation

@hassan-alam
Copy link
Contributor

hassan-alam commented Feb 1, 2020

Summary

This change is to introduce another test fixture for adding manual tests for checking to make sure form state (for controlled form components) is updated by browser autofill/autocomplete. This is tied to ticket 10468.

Test Plan

Streamable Video: https://streamable.com/fhx52

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Feb 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d4770b:

Sandbox Source
vigilant-bardeen-7lwue Configuration
@sizebot

This comment has been minimized.

Copy link

sizebot commented Feb 1, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 1d4770b

@sizebot

This comment has been minimized.

Copy link

sizebot commented Feb 1, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 1d4770b

@trueadm
trueadm approved these changes Feb 4, 2020
Copy link
Member

trueadm left a comment

This looks good. Thanks for the fixture! :)

@trueadm trueadm merged commit 2078aa9 into facebook:master Feb 4, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.