Skip to content

Fix sourcemaps in JSXTransformer for Firefox #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zpao merged 1 commit into from
Jul 9, 2014
Merged

Fix sourcemaps in JSXTransformer for Firefox #1801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion vendor/browser-transforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
var runScripts;
var loadScripts;
var headEl;
var dummyAnchor;

var buffer = require('buffer');
var transform = require('jstransform').transform;
Expand Down Expand Up @@ -124,13 +125,20 @@ var transformCode = function(code, source, options) {
if (inlineScriptCount > 1) {
source += ' (' + inlineScriptCount + ')';
Copy link
Collaborator

@sophiebits sophiebits Jul 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if these inline scripts work fine?

Copy link
Member Author

@zpao zpao Jul 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup :)

}
} else if (dummyAnchor) {
// Firefox has problems when the sourcemap source is a proper URL with a
// protocol and hostname, so use the pathname. We could use just the
// filename, but hopefully using the full path will prevent potential
// issues where the same filename exists in multiple directories.
dummyAnchor.href = source;
source = dummyAnchor.pathname.substr(1);
}
map.sources = [source];
map.sourcesContent = [code];

return (
transformed.code +
'//# sourceMappingURL=data:application/json;base64,' +
'\n//# sourceMappingURL=data:application/json;base64,' +
buffer.Buffer(JSON.stringify(map)).toString('base64')
);
} else {
Expand Down Expand Up @@ -226,6 +234,7 @@ runScripts = function() {

if (typeof window !== "undefined" && window !== null) {
headEl = document.getElementsByTagName('head')[0];
dummyAnchor = document.createElement('a');

if (window.addEventListener) {
window.addEventListener('DOMContentLoaded', runScripts, false);
Expand Down