Jsxtransformer cleanup #1802
Merged
Jsxtransformer cleanup #1802
+128
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
(I still want to get rid of the docblock for non-FB stuff and just use the .jsx extension and transform always if type="text/jsx"…)
Collaborator
|
Looks reasonable (though the comment from #1801 is still unclear to me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got carried away. I couldn't help myself.
Note: this also removes some APIs that were publicly exposed. I'll spot check react-rails and react-python to make sure they weren't using them. There was no need to make them public anyway.