Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: `memo` drops lower pri updates on bail out #18091

Merged
merged 1 commit into from Feb 21, 2020

Conversation

@acdlite
Copy link
Member

acdlite commented Feb 20, 2020

Fixes a bug where lower priority updates on a components wrapped with memo are sometimes left dangling in the queue without ever being processed, if they are preceded by a higher priority bailout.

Cause

The pending update priority field is cleared at the beginning of beginWork. If there is remaining work at a lower priority level, it's expected that it will be accumulated on the work-in-progress fiber during the begin phase.

There's an exception where this assumption doesn't hold: SimpleMemoComponent contains a bailout that occurs before the component is evaluated and the update queues are processed, which means we don't accumulate the next priority level. When we complete the fiber, the work loop is left to believe that there's no remaining work.

Mitigation

Since this only happens in a single case, a late bailout in SimpleMemoComponent, I've mitigated the bug in that code path by restoring the original update priority from the current fiber.

This same case does not apply to MemoComponent, because MemoComponent fibers do not contain hooks or update queues; rather, they wrap around an inner fiber that may contain those. However, I've added a test case for MemoComponent to protect against a possible future regression.

Possible next steps

We should consider moving the update priority assignment in beginWork out of the common path and into each branch, to avoid similar bugs in the future.

Fixes a bug where lower priority updates on a components wrapped with
`memo` are sometimes left dangling in the queue without ever being
processed, if they are preceded by a higher priority bailout.

Cause
-----

The pending update priority field is cleared at the beginning of
`beginWork`. If there is remaining work at a lower priority level, it's
expected that it will be accumulated on the work-in-progress fiber
during the begin phase.

There's an exception where this assumption doesn't hold:
SimpleMemoComponent contains a bailout that occurs *before* the
component is evaluated and the update queues are processed, which means
we don't accumulate the next priority level. When we complete the fiber,
the work loop is left to believe that there's no remaining work.

Mitigation
----------

Since this only happens in a single case, a late bailout in
SimpleMemoComponent, I've mitigated the bug in that code path by
restoring the original update priority from the current fiber.

This same case does not apply to MemoComponent, because MemoComponent
fibers do not contain hooks or update queues; rather, they wrap around
an inner fiber that may contain those. However, I've added a test case
for MemoComponent to protect against a possible future regression.

Possible next steps
-------------------

We should consider moving the update priority assignment in `beginWork`
out of the common path and into each branch, to avoid similar bugs in
the future.
@sizebot

This comment has been minimized.

Copy link

sizebot commented Feb 20, 2020

Details of bundled changes.

Comparing: ea6ed3d...0da64c2

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 123.81 KB 123.84 KB 38.73 KB 38.74 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
ReactDOM-dev.js +0.1% +0.2% 990.7 KB 991.96 KB 218.38 KB 218.85 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 708 B 709 B UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 55.99 KB 55.99 KB 15.78 KB 15.78 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% 0.0% 121.36 KB 121.39 KB 38.26 KB 38.27 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 139.77 KB 139.77 KB 37.1 KB 37.11 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.23 KB 11.23 KB 4.16 KB 4.17 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.26 KB 54.26 KB 15.47 KB 15.47 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 135.71 KB 135.71 KB 36.09 KB 36.09 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11 KB 11 KB 4.11 KB 4.11 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 20.39 KB 20.39 KB 7.47 KB 7.47 KB NODE_PROD
react-dom.development.js +0.1% +0.2% 970.41 KB 971.67 KB 217.97 KB 218.45 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 58.73 KB 58.73 KB 15.35 KB 15.36 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 119.96 KB 119.99 KB 38.34 KB 38.35 KB UMD_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.25 KB 10.25 KB 3.47 KB 3.47 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 140.47 KB 140.47 KB 35.55 KB 35.55 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 123.59 KB 123.63 KB 39.51 KB 39.52 KB UMD_PROFILING
react-dom.development.js +0.1% +0.2% 964.49 KB 965.75 KB 216.34 KB 216.81 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 58.43 KB 58.43 KB 15.28 KB 15.28 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 120.02 KB 120.06 KB 37.58 KB 37.59 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 9.99 KB 9.99 KB 3.37 KB 3.38 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 695 B 697 B NODE_PROD
ReactDOM-prod.js 0.0% 0.0% 373.6 KB 373.67 KB 67.86 KB 67.86 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% 0.0% 384.9 KB 384.97 KB 69.92 KB 69.93 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.05 KB 1.05 KB 639 B 641 B NODE_PROD
react-dom-testing.development.js +0.1% +0.2% 967.25 KB 968.51 KB 216.81 KB 217.28 KB UMD_DEV
react-dom-testing.production.min.js 0.0% 0.0% 117.6 KB 117.64 KB 37.88 KB 37.9 KB UMD_PROD
ReactDOMTesting-dev.js +0.1% +0.2% 990.2 KB 991.46 KB 218.25 KB 218.72 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.13 KB 121.16 KB 39.02 KB 39.01 KB UMD_PROFILING
ReactDOMTesting-prod.js 0.0% 0.0% 371.5 KB 371.57 KB 67.65 KB 67.65 KB FB_WWW_PROD
react-dom-testing.development.js +0.1% +0.2% 961.33 KB 962.59 KB 215.17 KB 215.66 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% 0.0% 371.5 KB 371.57 KB 67.65 KB 67.65 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% 0.0% 136.82 KB 136.82 KB 36.31 KB 36.32 KB NODE_DEV
react-dom-testing.production.min.js 0.0% 0.0% 117.68 KB 117.72 KB 37.18 KB 37.18 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.79 KB 20.79 KB 7.62 KB 7.62 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.2% +0.4% 625.88 KB 627.14 KB 129.28 KB 129.76 KB FB_WWW_DEV
react-art.development.js +0.2% +0.3% 682.86 KB 684.12 KB 146.94 KB 147.42 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 107.54 KB 107.58 KB 32.52 KB 32.51 KB UMD_PROD
react-art.development.js +0.2% +0.4% 613.53 KB 614.79 KB 129.53 KB 130 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 72.5 KB 72.54 KB 21.66 KB 21.67 KB NODE_PROD
ReactART-prod.js 0.0% 0.0% 233.07 KB 233.14 KB 39.28 KB 39.28 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.2% +0.4% 626.65 KB 627.91 KB 132.13 KB 132.59 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 72.16 KB 72.19 KB 21.96 KB 21.95 KB UMD_PROD
react-test-renderer.development.js +0.2% +0.4% 621.91 KB 623.17 KB 130.94 KB 131.42 KB NODE_DEV
react-test-renderer.production.min.js 0.0% 0.0% 71.93 KB 71.97 KB 21.63 KB 21.64 KB NODE_PROD
ReactTestRenderer-dev.js +0.2% +0.4% 637.38 KB 638.63 KB 131.78 KB 132.25 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 37.89 KB 37.89 KB 9.83 KB 9.84 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.66 KB 11.66 KB 3.6 KB 3.6 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 32.43 KB 32.43 KB 8.53 KB 8.53 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.79 KB 11.79 KB 3.71 KB 3.71 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js +0.2% +0.3% 721.91 KB 723.17 KB 152.6 KB 153.08 KB RN_FB_DEV
ReactFabric-prod.js 0.0% 0.0% 260.37 KB 260.43 KB 44.98 KB 44.98 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.2% +0.3% 731.21 KB 732.47 KB 154.65 KB 155.13 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% 0.0% 271.54 KB 271.61 KB 47.09 KB 47.1 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 267.71 KB 267.77 KB 46.25 KB 46.25 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 278.93 KB 279 KB 48.42 KB 48.42 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js +0.2% +0.3% 731.38 KB 732.64 KB 154.74 KB 155.21 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 268.1 KB 268.16 KB 46.31 KB 46.31 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 279.31 KB 279.38 KB 48.47 KB 48.48 KB RN_FB_PROFILING
ReactFabric-dev.js +0.2% +0.3% 721.72 KB 722.98 KB 152.52 KB 152.99 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 260.02 KB 260.08 KB 44.9 KB 44.91 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 271.19 KB 271.26 KB 47.02 KB 47.03 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js +0.2% +0.4% 615.84 KB 617.1 KB 128.6 KB 129.08 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% 0.0% 20.54 KB 20.54 KB 6.76 KB 6.76 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% 0.0% 73.76 KB 73.8 KB 21.79 KB 21.79 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% 🔺+0.2% 2.86 KB 2.86 KB 1.24 KB 1.24 KB NODE_PROD
react-reconciler.development.js +0.2% +0.4% 619.65 KB 620.91 KB 130.11 KB 130.58 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 76.52 KB 76.56 KB 22.44 KB 22.45 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: 🔺+0.1%

Size changes (experimental)

Generated by 🚫 dangerJS against 0da64c2

@sizebot

This comment has been minimized.

Copy link

sizebot commented Feb 20, 2020

Details of bundled changes.

Comparing: ea6ed3d...0da64c2

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js 0.0% 0.0% 408.56 KB 408.63 KB 74.28 KB 74.28 KB FB_WWW_PROFILING
react-dom-testing.production.min.js 0.0% 0.0% 117.15 KB 117.19 KB 37.04 KB 37.05 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 58.72 KB 58.72 KB 15.35 KB 15.35 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.04 KB 1.04 KB 631 B 633 B NODE_PROD
react-dom-testing.profiling.min.js 0.0% 0.0% 120.83 KB 120.86 KB 38.13 KB 38.13 KB NODE_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.24 KB 10.24 KB 3.46 KB 3.47 KB UMD_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.4 KB 4.4 KB 1.64 KB 1.64 KB NODE_DEV
react-dom.development.js +0.1% +0.2% 970.39 KB 971.65 KB 217.95 KB 218.43 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 687 B 689 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 116.04 KB 116.07 KB 37.24 KB 37.25 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 20 KB 20 KB 7.4 KB 7.4 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.56 KB 119.6 KB 38.4 KB 38.39 KB UMD_PROFILING
ReactDOMTesting-dev.js +0.1% +0.2% 990.19 KB 991.45 KB 218.24 KB 218.71 KB FB_WWW_DEV
react-dom.development.js +0.1% +0.2% 964.47 KB 965.73 KB 216.32 KB 216.8 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 383.81 KB 383.87 KB 69.73 KB 69.74 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 135.68 KB 135.68 KB 36.08 KB 36.08 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 116.08 KB 116.11 KB 36.56 KB 36.57 KB NODE_PROD
react-dom-testing.development.js +0.1% +0.2% 967.22 KB 968.48 KB 216.8 KB 217.27 KB UMD_DEV
ReactDOMTesting-profiling.js 0.0% 0.0% 383.81 KB 383.87 KB 69.73 KB 69.74 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 19.93 KB 19.93 KB 7.39 KB 7.39 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom.profiling.min.js 0.0% 0.0% 119.75 KB 119.78 KB 37.66 KB 37.66 KB NODE_PROFILING
react-dom-testing.production.min.js 0.0% 0.0% 117.07 KB 117.11 KB 37.72 KB 37.74 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 700 B 702 B UMD_PROD
ReactDOM-dev.js +0.1% +0.2% 991.64 KB 992.9 KB 218.69 KB 219.16 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.6 KB 120.63 KB 38.88 KB 38.87 KB UMD_PROFILING
ReactDOMServer-dev.js 0.0% 0.0% 140.46 KB 140.46 KB 35.55 KB 35.55 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 397.23 KB 397.3 KB 72.18 KB 72.19 KB FB_WWW_PROD
react-dom-testing.development.js +0.1% +0.2% 961.31 KB 962.57 KB 215.16 KB 215.64 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 48.98 KB 48.98 KB 11.18 KB 11.17 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.7 KB 3.7 KB 1.49 KB 1.49 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 58.42 KB 58.42 KB 15.27 KB 15.28 KB NODE_DEV
react-dom-test-utils.development.js 0.0% 0.0% 55.98 KB 55.98 KB 15.78 KB 15.78 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 9.98 KB 9.98 KB 3.37 KB 3.37 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 11.21 KB 11.21 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.25 KB 54.25 KB 15.46 KB 15.47 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 136.79 KB 136.79 KB 36.31 KB 36.31 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.99 KB 10.99 KB 4.1 KB 4.1 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.34 KB 20.34 KB 7.54 KB 7.54 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 0.0% 0.0% 267.69 KB 267.76 KB 46.24 KB 46.25 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 278.92 KB 278.98 KB 48.41 KB 48.42 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.2% +0.3% 721.71 KB 722.97 KB 152.51 KB 152.98 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 260 KB 260.07 KB 44.89 KB 44.9 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 271.18 KB 271.25 KB 47.01 KB 47.02 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js +0.2% +0.3% 731.2 KB 732.46 KB 154.65 KB 155.12 KB RN_OSS_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js +0.2% +0.4% 615.83 KB 617.09 KB 128.59 KB 129.07 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% 0.0% 73.75 KB 73.79 KB 21.78 KB 21.79 KB NODE_PROD
react-reconciler.development.js +0.2% +0.4% 619.64 KB 620.9 KB 130.11 KB 130.58 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% 0.0% 20.52 KB 20.52 KB 6.76 KB 6.76 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 73.74 KB 73.78 KB 21.77 KB 21.78 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% 🔺+0.2% 2.85 KB 2.85 KB 1.23 KB 1.24 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.production.min.js 🔺+0.1% 0.0% 69.99 KB 70.02 KB 20.99 KB 20.99 KB NODE_PROD
react-art.development.js +0.2% +0.3% 682.83 KB 684.09 KB 146.94 KB 147.41 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 104.98 KB 105.02 KB 31.84 KB 31.83 KB UMD_PROD
react-art.development.js +0.2% +0.4% 613.51 KB 614.77 KB 129.53 KB 130 KB NODE_DEV
ReactART-dev.js +0.2% +0.4% 625.87 KB 627.13 KB 129.28 KB 129.75 KB FB_WWW_DEV
ReactART-prod.js 0.0% 0.0% 240.58 KB 240.65 KB 40.5 KB 40.5 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.production.min.js 0.0% 0.0% 71.91 KB 71.94 KB 21.61 KB 21.62 KB NODE_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 32.42 KB 32.42 KB 8.52 KB 8.52 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.78 KB 11.78 KB 3.7 KB 3.7 KB NODE_PROD
react-test-renderer.development.js +0.2% +0.4% 626.62 KB 627.88 KB 132.11 KB 132.58 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 72.13 KB 72.17 KB 21.94 KB 21.94 KB UMD_PROD
react-test-renderer.development.js +0.2% +0.4% 621.89 KB 623.15 KB 130.92 KB 131.41 KB NODE_DEV
ReactTestRenderer-dev.js +0.2% +0.4% 637.36 KB 638.62 KB 131.78 KB 132.25 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 37.88 KB 37.88 KB 9.83 KB 9.83 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.64 KB 11.64 KB 3.59 KB 3.59 KB UMD_PROD

ReactDOM: size: 0.0%, gzip: 🔺+0.1%

Size changes (stable)

Generated by 🚫 dangerJS against 0da64c2

@dai-shi

This comment has been minimized.

Copy link

dai-shi commented Feb 20, 2020

Hi, possibly related with #17318 (and #17314 and #17028)?

@acdlite acdlite merged commit 5de5b61 into facebook:master Feb 21, 2020
21 checks passed
21 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
@acdlite

This comment has been minimized.

Copy link
Member Author

acdlite commented Feb 21, 2020

@dai-shi Yes probably. I'll confirm in a sec.

This was referenced Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.