Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop exposing ReactDOMComponentTree from FB builds #18338

Merged
merged 1 commit into from Mar 18, 2020

Conversation

@gaearon
Copy link
Member

gaearon commented Mar 18, 2020

I'm changing the only usage in D20512780 to read the internals directly. Let's get rid of this.

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Mar 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50bd189:

Sandbox Source
stoic-shaw-89r78 Configuration
@sizebot

This comment has been minimized.

Copy link

sizebot commented Mar 18, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 50bd189

@sizebot

This comment has been minimized.

Copy link

sizebot commented Mar 18, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 50bd189

@gaearon gaearon requested a review from sebmarkbage Mar 18, 2020
@gaearon gaearon merged commit 1cf4a17 into facebook:master Mar 18, 2020
31 checks passed
31 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_prod Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant_prod Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant_prod_experimental Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.