Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactDOM: remove unstable-native-dependencies bundle #18483

Merged

Conversation

@necolas
Copy link
Contributor

@necolas necolas commented Apr 3, 2020

This is only used by react-native-web and will be replaced by a user-space
implementation

Summary

See: necolas/react-native-web#1568

Test Plan

CI

@codesandbox
Copy link

@codesandbox codesandbox bot commented Apr 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9fe5ee0:

Sandbox Source
xenodochial-chatterjee-n9gch Configuration
Copy link
Member

@sebmarkbage sebmarkbage left a comment

When do we actually merge this? Before the official RNW release has it or after? Seems like we should wait until there's actually an upgrade path? Since this is a breaking change, I think it'll also have to wait until we're finished releasing minors and are ready for a major.

scripts/rollup/bundles.js Show resolved Hide resolved
@sizebot
Copy link

@sizebot sizebot commented Apr 3, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 9fe5ee0

@sizebot
Copy link

@sizebot sizebot commented Apr 3, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 9fe5ee0

@necolas
Copy link
Contributor Author

@necolas necolas commented Apr 3, 2020

I think it'll also have to wait until we're finished releasing minors and are ready for a major

Probably. I'm expecting to get the replacement into RNW by the end of the month. This doesn't strictly need to go out in a major, since previous breaking changes in these files have occurred in patch releases. However, if there's anything else related to the plugin system that we want to remove once this is merged, then it would make sense to package it all up in a major.

@necolas necolas force-pushed the necolas:react-dom/remove-unstable-native-deps-bundle branch from b6d14ac to 66b1903 Apr 4, 2020
This is only used by react-native-web and will be replaced by a user-space
implementation. See: necolas/react-native-web#1568
@necolas necolas force-pushed the necolas:react-dom/remove-unstable-native-deps-bundle branch from 66b1903 to 9fe5ee0 Apr 4, 2020
@necolas
Copy link
Contributor Author

@necolas necolas commented Apr 16, 2020

I'm happy to merge this now, and will be responsible for managing the downstream effects.

@necolas necolas merged commit 9620324 into facebook:master Apr 18, 2020
31 checks passed
31 checks passed
ci/circleci: NODE_ENV_production_yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: NODE_ENV_production_yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_persistent Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: sizebot_stable Your tests passed on CircleCI!
Details
ci/circleci: yarn_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_flow Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.