Skip to content

Automated DevTools release process #22161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bvaughn merged 8 commits into from
Aug 24, 2021
Merged

Automated DevTools release process #22161

bvaughn merged 8 commits into from
Aug 24, 2021
+1,143 −114

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 24, 2021 •
edited
Loading

  • Automate Git commit
  • Automate build and yarn build and npm publish steps
  • Add publish instructions for extension stores
devtools-release-script.mp4

@bvaughn bvaughn requested review from jstejada and lunaruan August 24, 2021 04:31
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 24, 2021
@bvaughn bvaughn force-pushed the devtools-release-script branch from 9ac913e to 51c5d42 Compare August 24, 2021 04:34
@sizebot
Copy link

sizebot commented Aug 24, 2021 •
edited
Loading

Comparing: bd5bf55...42cea6e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.58 kB 127.58 kB = 40.72 kB 40.72 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.40 kB 130.40 kB = 41.65 kB 41.65 kB
facebook-www/ReactDOM-prod.classic.js = 405.16 kB 405.16 kB = 75.04 kB 75.04 kB
facebook-www/ReactDOM-prod.modern.js = 393.72 kB 393.72 kB = 73.32 kB 73.32 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.16 kB 405.16 kB = 75.04 kB 75.04 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 42cea6e

jstejada
jstejada approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@jstejada jstejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty great so far! pre-emptive approval. one suggestion is that you might want to change the title of the PR?

packages/react-devtools-extensions/chrome/manifest.json
{
"manifest_version": 2,
"name": "React Developer Tools",
"description": "Adds React debugging tools to the Chrome Developer Tools.",
Copy link
Contributor

@jstejada jstejada Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commit relevant to the script in some way?

Copy link
Contributor Author

@bvaughn bvaughn Aug 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I updated the manifest.json files in their own commit to match the format generated by JSON.stringify(json, null, 2) so the version update script would only affect version numbers (and no other formatting changes).

scripts/devtools/release.js
});
}

function updatePackageVersions(previousVersion, nextVersion) {
Copy link
Contributor

@jstejada jstejada Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@bvaughn bvaughn marked this pull request as ready for review August 24, 2021 17:36
@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 24, 2021

looks pretty great so far! pre-emptive approval. one suggestion is that you might want to change the title of the PR?

Thanks!

Yeah, GitHub defaults a PR title to the first commit 😂 Fixed.

@bvaughn bvaughn changed the title Moved DevTools get-commit-list script into the scripts/devtools directory Automated DevTools release process Aug 24, 2021
jstejada
jstejada approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@jstejada jstejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!!

@bvaughn bvaughn merged commit b5fbf54 into facebook:main Aug 24, 2021
@bvaughn bvaughn deleted the devtools-release-script branch August 24, 2021 18:05
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
@zhengjitf
Automated DevTools release process (facebook#22161)
a0f3690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jstejada jstejada jstejada approved these changes

@lunaruan lunaruan lunaruan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed Component: Developer Tools React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bvaughn @sizebot @jstejada @lunaruan @facebook-github-bot