Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imageSizes and imageSrcSet to know props #22550

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 13, 2021

Summary

Adds imageSizes and imageSrcSet to know props.
Spec: https://html.spec.whatwg.org/multipage/semantics.html#the-link-element

Note that the capitalization of imageSrcSet doesn't match the DOM property but follows <img srcSet /> capitalization.

How did you test this change?

@sizebot
Copy link

sizebot commented Oct 13, 2021

Comparing: cbc484b...64164e2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.01 kB 130.01 kB = 41.57 kB 41.57 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.77 kB 134.77 kB = 42.96 kB 42.97 kB
facebook-www/ReactDOM-prod.classic.js = 424.63 kB 424.63 kB = 78.24 kB 78.24 kB
facebook-www/ReactDOM-prod.modern.js = 413.19 kB 413.19 kB = 76.51 kB 76.51 kB
facebook-www/ReactDOMForked-prod.classic.js = 424.63 kB 424.63 kB = 78.25 kB 78.25 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 64164e2

@eps1lon eps1lon marked this pull request as ready for review October 13, 2021 12:19
@gaearon
Copy link
Collaborator

gaearon commented Nov 24, 2021

Do we understand where the other attribute table changes (matching main) are coming from? Feels uncomfortable to proceed until we know we haven't had an accidental regression in the meantime.

@gaearon
Copy link
Collaborator

gaearon commented Nov 24, 2021

I guess that's really a question about #22522.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Nov 24, 2021

I guess that's really a question about #22522.

Yep, #22522 should go in first. Though I'll rebase #22522 first to check if nothing changed in the meantime.

And then I'll run the attribute fixture with the repo being checked at the point where we last updated them to see if the changes are indeed caused by browser updates.

We should probably include the browser version that created the snapshot in the attribute fixture as well.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Nov 24, 2021

@gaearon Updated #22522 and reduced it to two notable changes that should be reviewed:

  1. Update attribute-behavior fixture #22522 (comment)
  2. Update attribute-behavior fixture #22522 (comment)

@gaearon gaearon merged commit ca106a0 into facebook:main Nov 25, 2021
@eps1lon eps1lon deleted the feat/imageSrcSet branch November 25, 2021 01:53
@gaearon gaearon mentioned this pull request Mar 29, 2022
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
* feat(react-dom): Add `imageSrcSet`

* feat(react-dom): Add `imageSizes`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants