Skip to content

Remove flushControlled from experimental releases #23384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 1 commit into from
Feb 28, 2022
Merged

Remove flushControlled from experimental releases #23384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-dom/index.experimental.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export {
render,
unmountComponentAtNode,
unstable_batchedUpdates,
unstable_flushControlled,
unstable_renderSubtreeIntoContainer,
unstable_runWithPriority, // DO NOT USE: Temporarily exposed to migrate off of Scheduler.runWithPriority.
version,
Expand Down
6 changes: 3 additions & 3 deletions packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ describe('ReactDOMFiberAsync', () => {
expect(ops).toEqual(['BC', 'ABCD']);
});

// @gate experimental || www
// @gate www
it('flushControlled flushes updates before yielding to browser', () => {
let inst;
class Counter extends React.Component {
Expand Down Expand Up @@ -326,7 +326,7 @@ describe('ReactDOMFiberAsync', () => {
]);
});

// @gate experimental || www
// @gate www
it('flushControlled does not flush until end of outermost batchedUpdates', () => {
let inst;
class Counter extends React.Component {
Expand Down Expand Up @@ -357,7 +357,7 @@ describe('ReactDOMFiberAsync', () => {
]);
});

// @gate experimental || www
// @gate www
it('flushControlled returns nothing', () => {
// In the future, we may want to return a thenable "work" object.
let inst;
Expand Down