Explicitly set highWaterMark to 0 for ReadableStream#24641
Merged
sebmarkbage merged 2 commits intofacebook:mainfrom May 31, 2022
Merged
Explicitly set highWaterMark to 0 for ReadableStream#24641sebmarkbage merged 2 commits intofacebook:mainfrom
highWaterMark to 0 for ReadableStream#24641sebmarkbage merged 2 commits intofacebook:mainfrom
Conversation
This is because not all streaming implementations respect the default behavior of settings highWaterMark to 0 for byte streams. Being explicit guarantees the intended behavior across runtimes.
|
Comparing: 1328ff7...fff3966 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Contributor
|
You're getting failed tests due the |
Contributor
Author
|
Ahh, Flow doesn't like any queuingStrategy without a I've updated with I tried implementing https://developer.mozilla.org/en-US/docs/Web/API/ByteLengthQueuingStrategy but Flow doesn't seem to recognize that as a valid thing, either. |
4 tasks
This was referenced Mar 4, 2023
This was referenced Nov 7, 2024
This was referenced Nov 7, 2024
This was referenced Nov 8, 2024
This was referenced Nov 9, 2024
This was referenced Nov 10, 2024
This was referenced Nov 10, 2024
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
This was referenced Nov 12, 2024
This was referenced Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is because not all streaming implementations (e.g. Cloudflare) respect the default behavior of settings
highWaterMarkto 0 for byte streams: 75662d6Related Hydrogen bug: Shopify/hydrogen#1383
Being explicit guarantees the intended behavior across runtimes. I've contacted Cloudflare, and they are working on fixing this in their implementation in the meantime.
How did you test this change?
highWaterMarkmanually in the compiled source code